Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CI to latest redis versions #163

Merged
merged 24 commits into from
Aug 14, 2023
Merged

Updating CI to latest redis versions #163

merged 24 commits into from
Aug 14, 2023

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Jul 31, 2023

Updating the versions of redis used by CI for integration testing. Changes were made only to the github actions, there are no code changes.
Closes #164

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (af0d5fa) 93.99% compared to head (b99dc71) 93.99%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #163   +/-   ##
=======================================
  Coverage   93.99%   93.99%           
=======================================
  Files          82       82           
  Lines        5080     5080           
  Branches      479      479           
=======================================
  Hits         4775     4775           
  Misses        177      177           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shacharPash
Copy link
Contributor

@chayim the CI failed, do you want to fix it?

@chayim chayim changed the title Redis version bump Updating CI to latest redis versions Aug 10, 2023
@shacharPash shacharPash requested a review from slorello89 August 10, 2023 10:30
@shacharPash shacharPash requested a review from slorello89 August 13, 2023 12:54
Copy link
Member

@slorello89 slorello89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shacharPash shacharPash merged commit 244ebbf into master Aug 14, 2023
@shacharPash shacharPash deleted the ck-redisverisons branch August 14, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding an attribute for skipping tests if Redis version is greater/lower than X
5 participants